OAK-11697: Indexing / query limit / traversal error: improve diagnostics #2626
+64
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extended logging and error message.
Minor optimization.
Minor optimization.
reschke
reviewed
Nov 27, 2025
reschke
reviewed
Nov 27, 2025
Contributor
reschke
left a comment
reschke
left a comment
There was a problem hiding this comment.
and the extended exception messsage will propagate up? maybe add a simple test case?
Re-formatted diagnostic text, added test case.
reschke
approved these changes
Nov 28, 2025
|
reschke
reviewed
Dec 10, 2025
Contributor
reschke
left a comment
reschke
left a comment
There was a problem hiding this comment.
LGTM, but it would be nice to hear from @thomasmueller
reschke
reviewed
Dec 10, 2025
| traversal = queryOptions.traversal; | ||
| } | ||
| String caller = IndexUtils.getCaller(settings.getIgnoredClassNamesInCallTrace()); | ||
| String message = "Traversal query (query without index): " + statement + "; called by " + caller + "; consider creating an index"; |
Contributor
There was a problem hiding this comment.
would indeed be nice to refactor this slightly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.